On Mon, Jan 06, 2014 at 12:24:38PM +0100, Klaus Schmidinger wrote:

On 06.01.2014 11:28, Antti Hartikainen wrote:

...

Hi.

I thought it would be time to finally update outdated sources.conf. Patch is against sources.conf delivered with VDR 2.1.3.

Some things came up, and I would like to hear some opinions about them.

There was/is entries like:

S28.2E for Astra 2 satellites and S28.5E for Eutelsat satellite at almost same orbital position

Both satellites are supposed to be watched with one dish and LNB, but still they have their own entries in sources.conf.

Similar example is "S1W Thor 5/6 & Intelsat 10-02". Thor satellites are positioned 0.2 degrees apart from Intelsat.

So should these satellites nearby eachother to be combined as one, or should every one to be separated as its own position?

If these are officially two separate positions, they should be contained as such in sources.conf. I have encountered the same problem while implementing the DiSEqC configuration dialog. My approach will be to make cDiseqcs::Get() search for a suitable DiSEqC entry with a certain tolerance. A value of +/-0.3 degrees would cover the cases you mentioned. Or should it be even +/-0.5?

This is why I wanted to join them together, so if such change will be made, separate close to eachother positions don't really matter. I think 0.5 degrees might be too much apart (depends of configuration.. dish size specially) and rare condition, and making VDR to steer dish "in between" two would make too much complicity, right?

...

In this patch I have combined 28.2E and 28.5E positions as one 28.2E position, as atleast I have set them both up as one single position.

Sorry, I don't think this is a good idea. Please make them separate again if you want your patch to be adopted.

Thanks for the feedback. I wasn't aware if this is intentional or just by mistake. I changed it back to two separate positions in revised patch.

...

I also wanted to change S1W to S0.8W, as it's more true, but I can imagine it would cause a lot of trouble for people who are using the default sources.conf file as their sources.conf, so for now I left it as is. It doesn't really matter, but improves signal strength for people using USALS. :)

The satellite position that is broadcast in the SatelliteDeliverySystemDescriptor's OrbitalPosition/EastWestFlag on that satellite actually says 1.0W, so I'd say that's what should be in sources.conf.

I agree. I haven't examined any of such data that satellites may broadcast. Ofcourse I would prefer to keep official values for them. I made some slight changes to some postions like 3E -> 3.1E, but I have changed them back to original in revised patch. I didn't check what they broadcast, as I don't have knowhow to read such broadcast information from stream. There was some completely new positions in Asia and America region, so I have no possiblity to check any official positions for them anyway, as I reside in Europe and have no possibility to receive them.

So v2 patch does not change any positions, only changes satellite names and adds new and removes old, no longer used satellite positions. Also in v2 changed "Hotbird" to "Eutelsat Hot Bird", as it is now called as such.

On 06.01.2014 13:39, Antti Hartikainen wrote:

On Mon, Jan 06, 2014 at 12:24:38PM +0100, Klaus Schmidinger wrote:

...

On 06.01.2014 11:28, Antti Hartikainen wrote:

...

Hi.

I thought it would be time to finally update outdated sources.conf. Patch is against sources.conf delivered with VDR 2.1.3.

Some things came up, and I would like to hear some opinions about them.

There was/is entries like:

S28.2E for Astra 2 satellites and S28.5E for Eutelsat satellite at almost same orbital position

Both satellites are supposed to be watched with one dish and LNB, but still they have their own entries in sources.conf.

Similar example is "S1W Thor 5/6 & Intelsat 10-02". Thor satellites are positioned 0.2 degrees apart from Intelsat.

So should these satellites nearby eachother to be combined as one, or should every one to be separated as its own position?

If these are officially two separate positions, they should be contained as such in sources.conf. I have encountered the same problem while implementing the DiSEqC configuration dialog. My approach will be to make cDiseqcs::Get() search for a suitable DiSEqC entry with a certain tolerance. A value of +/-0.3 degrees would cover the cases you mentioned. Or should it be even +/-0.5?

This is why I wanted to join them together, so if such change will be made, separate close to eachother positions don't really matter. I think 0.5 degrees might be too much apart (depends of configuration.. dish size specially) and rare condition, and making VDR to steer dish "in between" two would make too much complicity, right?

This "tolerance" would mainly apply to setups that have a fixed dish pointing to a position at which there are two satellites close together. In my upcoming DiSEqC configuration dialog it will be only possible to specify *one* sat position per LNB, so the tolerance will allow receiving both positions in such cases. Whether the dish is actually directed to either one of the satellites, or "in between", is up to the user, depending on which position his preferred.

If you have a motor dish it will always be positioned exactly to the requested angle, so there's no need to go "in between". And that's also a reason why sources.conf should contain separate values in such cases.

Thanks for the revised patch (v3).

Klaus