Hi, I found that there is a memory leak in the SVDR LSTE command. The socket file descriptor is fdopen'ed to dump the schedule data, but the stream is never fclose'ed. The memory associated with the stream is lost.
As simply fclosing the stream would close the socket as well, the solution is to dup the socket first.
Patch attached.
Regards.
Stefan Huelswitt wrote:
Hi, I found that there is a memory leak in the SVDR LSTE command. The socket file descriptor is fdopen'ed to dump the schedule data, but the stream is never fclose'ed. The memory associated with the stream is lost.
As simply fclosing the stream would close the socket as well, the solution is to dup the socket first.
Patch attached.
Please make future patches so that they don't cause so many unnecessary whitespace changes ;-)
Klaus
On 04 Jul 2005 Klaus Schmidinger Klaus.Schmidinger@cadsoft.de wrote:
Stefan Huelswitt wrote:
Patch attached.
Please make future patches so that they don't cause so many unnecessary whitespace changes ;-)
Well, one may argue about what is necessary and what not.
The patch adds one brace level, the indention has to be adjusted. So I thing the whitespaces are necessary ;)
Or would you prefer patches with -b?
Regards.
Stefan Huelswitt wrote:
On 04 Jul 2005 Klaus Schmidinger Klaus.Schmidinger@cadsoft.de wrote:
Stefan Huelswitt wrote:
Patch attached.
Please make future patches so that they don't cause so many unnecessary whitespace changes ;-)
Well, one may argue about what is necessary and what not.
The patch adds one brace level, the indention has to be adjusted. So I thing the whitespaces are necessary ;)
Oh, you're right. I just looked over it quickly and saw
+ if (fd) { + FILE *f = fdopen(fd, "w");
where the second line is not indented correctly, so that must have triggered my message...
Klaus
-
Klaus Schmidinger -
s.huelswitt＠gmx.de