VDR developer version 1.7.21 is now available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.21.tar.bz2
A 'diff' against the previous version is available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.20-1.7.21.diff
MD5 checksums:
7300bfd997db1a848bd774fefe4aec80 vdr-1.7.21.tar.bz2 c4e745939f31543dd607b97d58fc86be vdr-1.7.20-1.7.21.diff
WARNING: ========
This is a *developer* version. Even though *I* use it in my productive environment. I strongly recommend that you only use it under controlled conditions and for testing and debugging.
This version contains functions to determine the "signal strength" and "signal quality" through cDevice. If you are using a DVB card that contains an stb0899 frontend chip (like the TT-budget S2-3200) you may want to apply the patches from
ftp://ftp.tvdr.de/vdr/Developer/Driver-Patches
to the LinuxDVB driver source in order to receive useful results from that frontend.
The changes since version 1.7.20:
- Fixed detecting frames for channels that split frames into several payloads (reported by Derek Kelly). - Now initializing Setup.InitialChannel to an empty string to avoid problems in case there is no setup.conf. - The start time of an edited recording is now set to the time of the first editing mark (thanks to Udo Richter). This obsoletes the CUTTIME patch. - Direct access to the members start, priority, lifetime, and deleted of cRecording as well as to position and comment of cMark is now deprecated. Plugin authors should switch to the new access functions for these members. For now the macro __RECORDING_H_DEPRECATED_DIRECT_MEMBER_ACCESS is defined in recording.h, which exposes these members, so that existing plugins will still compile. Comment out this #define to check whether a particular plugin needs to be modified. This #define may be removed in a future version. - The new functions cRecording::NumFrames() and cRecording::LengthInSeconds() return the number of frames and length (in seconds) of a recording (suggested by Steffen Barszus). - The subtitle PIDs are now stored in the channels.conf file as an extension to the TPID field (thanks to Rolf Ahrenberg). - The new function cDevice::ProvidesEIT() is used to determine whether a device can provide EIT data and will thus be used in cEITScanner::Process() to receive EIT data from the channels it can receive (suggested by Rolf Ahrenberg). Note that by default it is assumed that a device can't provide EIT data, and only the builtin cDvbDevice returns true from this function. - The Audio and Subtitles options are now available through the Green and Yellow keys in the Setup/DVB menu (thanks to Rolf Ahrenberg). This is mainly for remote controls that don't have dedicated keys for these functions. - The SVDRP command HITK now accepts multiple keys (up to 31). - The Recordings menu now displays the length (in hours:minutes) of each recording (thanks to Rolf Ahrenberg). Note that the "new" indicator has been moved from the recording time to the length column. This new format is also used by the SVDRP command LSTR, so in case you have an application that parses the LSTR output, you will need to adjust it to the new format. - The dvbsddevice plugin now supports the new option --outputonly, which disables receiving on SD FF devices and uses the device only for output (thanks to Udo Richter). - Fixed detecting frames on radio channels (reported by Chris Mayo). - Revoked the changes to cFrameDetector that have been introduced in version 1.7.19. Detecting frames in case the Picture Start Code or Access Unit Delimiter extends over TS packet boundaries is now done by locally skipping TS packets in cFrameDetector.
Have fun!
Klaus
Al 04/09/11 15:42, En/na Klaus Schmidinger ha escrit:
- The subtitle PIDs are now stored in the channels.conf file as an extension to the TPID field (thanks to Rolf Ahrenberg).
When I start a recording on a satellite that's not the one the dish is pointing at, when it finally reaches the position the recording will have no subtitles. It also happens in live view, but then I can switch transponder and switch it back to get the subtitles. Does this modification fix the issue?
Bye
On 04.09.2011 16:20, Luca Olivetti wrote:
Al 04/09/11 15:42, En/na Klaus Schmidinger ha escrit:
- The subtitle PIDs are now stored in the channels.conf file as an extension to the TPID field (thanks to Rolf Ahrenberg).
When I start a recording on a satellite that's not the one the dish is pointing at, when it finally reaches the position the recording will have no subtitles. It also happens in live view, but then I can switch transponder and switch it back to get the subtitles. Does this modification fix the issue?
It might - there's one way to find out ;-)
Klaus
Al 04/09/11 17:22, En/na Luca Olivetti ha escrit:
Al 04/09/11 16:41, En/na Klaus Schmidinger ha escrit:
Does this modification fix the issue?
It might - there's one way to find out ;-)
Well, I'm getting old, so I try the "latest and greatest" only if it's strictly necessary :-D
Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are "whacky": they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-(
Bye
On 04.09.2011 19:54, Luca Olivetti wrote:
Al 04/09/11 17:22, En/na Luca Olivetti ha escrit:
Al 04/09/11 16:41, En/na Klaus Schmidinger ha escrit:
Does this modification fix the issue?
It might - there's one way to find out ;-)
Well, I'm getting old, so I try the "latest and greatest" only if it's strictly necessary :-D
Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are "whacky": they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-(
I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters.
Klaus
Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit:
Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are "whacky": they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-(
I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters.
Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData) and the subtitles now work fine, both with the dxr3 and xine, in sd and hd (of course the latter only with xine). I have to say that with this version of vdr the subtitles are recorded even if the dish is not positioned at the start of the recording.
Bye
Al 04/09/11 23:53, En/na Luca Olivetti ha escrit:
Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit:
Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are "whacky": they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-(
I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters.
Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData)
It still works better with the above "fix", but maybe there's a typo in there:
shouldn't
osdFactorX = VideoAspect * OsdHeight / displayWidth;
be instead
osdFactorX = VideoAspect * OsdHeight / displayHeight;
?
On 05.09.2011 00:08, Luca Olivetti wrote:
Al 04/09/11 23:53, En/na Luca Olivetti ha escrit:
Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit:
Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are "whacky": they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-(
I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters.
Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData)
It still works better with the above "fix", but maybe there's a typo in there:
shouldn't
osdFactorX = VideoAspect * OsdHeight / displayWidth;
be instead
osdFactorX = VideoAspect * OsdHeight / displayHeight;
I don't think so.
'VideoAspect * OsdHeight' is the width of a full screen subtitle display, using the entire OSD height, according to the aspect ratio of the video material. Dividing this by displayWidth (i.e. the actual width of the subtitle display) results in the osdFactorX, which is used to convert coordinates in the subtitle display to the OSD coordinate system.
Can you provide me with some sample recording that demonstrates the problem you are seeing?
Klaus
Al 05/09/11 18:15, En/na Klaus Schmidinger ha escrit:
On 05.09.2011 00:08, Luca Olivetti wrote:
Al 04/09/11 23:53, En/na Luca Olivetti ha escrit:
Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit:
Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are "whacky": they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-(
I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters.
Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData)
It still works better with the above "fix", but maybe there's a typo in there:
shouldn't
osdFactorX = VideoAspect * OsdHeight / displayWidth;
be instead
osdFactorX = VideoAspect * OsdHeight / displayHeight;
I don't think so.
'VideoAspect * OsdHeight' is the width of a full screen subtitle display, using the entire OSD height, according to the aspect ratio of the video material. Dividing this by displayWidth (i.e. the actual width of the subtitle display) results in the osdFactorX, which is used to convert coordinates in the subtitle display to the OSD coordinate system.
Ok, I got confused, but why do you use VideoAspect * OsdHeight instead of OsdWidth? Most probably the problem is caused because the dxr3 plugin doesn't implement the GetOsdSize and GetVideoSize method, but the xine plugin does implement them. Anyway, since the cDevice::GetVideoSize returns 0 if not overridden, I put a check VideoWidth == 0 in SetOsdData.
Can you provide me with some sample recording that demonstrates the problem you are seeing?
I think you can check by yourself: I tested with the bbc channels at 28.2E.
Bye
Al 05/09/11 19:43, En/na Luca Olivetti ha escrit:
Ok, I got confused, but why do you use VideoAspect * OsdHeight instead of OsdWidth? Most probably the problem is caused because the dxr3 plugin doesn't implement the GetOsdSize and GetVideoSize method, but the xine plugin does implement them.
Ok, I had to setup the osd extents in xine to 1920x1080 to fix the issue.
Anyway, since the cDevice::GetVideoSize returns 0 if not overridden, I put a check VideoWidth == 0 in SetOsdData.
I think this is still needed for output plugins that don't implement the method, so that they should at least work as before this modification.
Bye
On 05.09.2011 19:52, Luca Olivetti wrote:
Al 05/09/11 19:43, En/na Luca Olivetti ha escrit:
Ok, I got confused, but why do you use VideoAspect * OsdHeight instead of OsdWidth? Most probably the problem is caused because the dxr3 plugin doesn't implement the GetOsdSize and GetVideoSize method, but the xine plugin does implement them.
Ok, I had to setup the osd extents in xine to 1920x1080 to fix the issue.
Anyway, since the cDevice::GetVideoSize returns 0 if not overridden, I put a check VideoWidth == 0 in SetOsdData.
I think this is still needed for output plugins that don't implement the method, so that they should at least work as before this modification.
Can you please point out exactly which modificaton you are referring to?
Klaus
Al 09/09/11 16:54, En/na Klaus Schmidinger ha escrit:
I think this is still needed for output plugins that don't implement the method, so that they should at least work as before this modification.
Can you please point out exactly which modificaton you are referring to?
I'm referring to the modification that changed GetVideoSize from being purely informational to being used for something. In case you're interested, with the patch below, output plugins that don't implement GetVideoSize will have the subtitles working as before. I know that the proper fix is to implement GetVideoSize and GetOsdSize (I actually did afterwards), but at least it doesn't break what was working before.
--- dvbsubtitle.c.orig 2011-09-04 19:11:12.426133000 +0200 +++ dvbsubtitle.c 2011-09-09 19:27:46.064725000 +0200 @@ -887,7 +887,7 @@ double VideoAspect; cDevice::PrimaryDevice()->GetOsdSize(OsdWidth, OsdHeight, OsdAspect); cDevice::PrimaryDevice()->GetVideoSize(VideoWidth, VideoHeight, VideoAspect); - if (OsdWidth == displayWidth && OsdHeight == displayHeight) { + if ((OsdWidth == displayWidth && OsdHeight == displayHeight) || VideoWidth == 0) { osdFactorX = osdFactorY = 1.0; osdDeltaX = osdDeltaY = 0; }
Bye
On 09.09.2011 19:37, Luca Olivetti wrote:
Al 09/09/11 16:54, En/na Klaus Schmidinger ha escrit:
I think this is still needed for output plugins that don't implement the method, so that they should at least work as before this modification.
Can you please point out exactly which modificaton you are referring to?
I'm referring to the modification that changed GetVideoSize from being purely informational to being used for something. In case you're interested, with the patch below, output plugins that don't implement GetVideoSize will have the subtitles working as before. I know that the proper fix is to implement GetVideoSize and GetOsdSize (I actually did afterwards), but at least it doesn't break what was working before.
--- dvbsubtitle.c.orig 2011-09-04 19:11:12.426133000 +0200 +++ dvbsubtitle.c 2011-09-09 19:27:46.064725000 +0200 @@ -887,7 +887,7 @@ double VideoAspect; cDevice::PrimaryDevice()->GetOsdSize(OsdWidth, OsdHeight, OsdAspect); cDevice::PrimaryDevice()->GetVideoSize(VideoWidth, VideoHeight, VideoAspect);
- if (OsdWidth == displayWidth&& OsdHeight == displayHeight) {
- if ((OsdWidth == displayWidth&& OsdHeight == displayHeight) || VideoWidth == 0) { osdFactorX = osdFactorY = 1.0; osdDeltaX = osdDeltaY = 0; }
You're right - adopted for 1.7.22.
Klaus
On 05.09.2011 19:43, Luca Olivetti wrote:
Al 05/09/11 18:15, En/na Klaus Schmidinger ha escrit:
On 05.09.2011 00:08, Luca Olivetti wrote:
Al 04/09/11 23:53, En/na Luca Olivetti ha escrit:
Al 04/09/11 23:05, En/na Klaus Schmidinger ha escrit:
Ok, I couldn't resist and I tried. I don't know if it solves the issue because now the subtitles are "whacky": they only appear from time to time and they're in the middle of the screen, both with my trusty dxr3 and with the xine plugin (in the latter case it happens both with sd and hd channels). Oh well, back to vdr-1.7.16 until I can investigate what's wrong :-(
I tested this with several old recordings and also live (in HD) and the subtitles always worked just fine. I'm using a TT-S2 6400 as output device, if that matters.
Well, I disabled the scaling/offset (in cDvbSubtitleConverter::SetOsdData)
It still works better with the above "fix", but maybe there's a typo in there:
shouldn't
osdFactorX = VideoAspect * OsdHeight / displayWidth;
be instead
osdFactorX = VideoAspect * OsdHeight / displayHeight;
I don't think so.
'VideoAspect * OsdHeight' is the width of a full screen subtitle display, using the entire OSD height, according to the aspect ratio of the video material. Dividing this by displayWidth (i.e. the actual width of the subtitle display) results in the osdFactorX, which is used to convert coordinates in the subtitle display to the OSD coordinate system.
Ok, I got confused, but why do you use VideoAspect * OsdHeight instead of OsdWidth?
Assume the OSD aspect is 16:9 and the currently displayed video material is 4:3. To properly map the subtitles on the 16:9 OSD you need to do VideoAspect * OsdHeight to get the proper width, assuming that the full height shall be used.
Most probably the problem is caused because the dxr3 plugin doesn't implement the GetOsdSize and GetVideoSize method, but the xine plugin does implement them. Anyway, since the cDevice::GetVideoSize returns 0 if not overridden, I put a check VideoWidth == 0 in SetOsdData.
Can you provide me with some sample recording that demonstrates the problem you are seeing?
I think you can check by yourself: I tested with the bbc channels at 28.2E.
Since you're saying that the problem is related to the dxr3 plugin I guess I won't see any error with my TT-S2 6400.
Klaus
Hi,
Am 09.09.2011 16:54, schrieb Klaus Schmidinger:
Since you're saying that the problem is related to the dxr3 plugin I guess I won't see any error with my TT-S2 6400.
I switch to 1.7.21 from 1.7.17 and see that teletext subtitles appear now for example on Das Erste HD.
No matter which OSD size I setup in vdr-xine (e. g. 720x576, 1280x720 or 1920x1080), the subtitles are never positioned correctly and vdr-xine complains very often like that:
vdr-xine: new OSD(-152, 0) requested with coordinates out of range
Do these subtitles work correctly on your TT-S2 6400? Which OSD size do you use on your TT-S2 6400?
Bye.
On 09/09/2011 10:19 PM, Reinhard Nissl wrote:
Hi,
Am 09.09.2011 16:54, schrieb Klaus Schmidinger:
Since you're saying that the problem is related to the dxr3 plugin I guess I won't see any error with my TT-S2 6400.
I switch to 1.7.21 from 1.7.17 and see that teletext subtitles appear now for example on Das Erste HD.
No matter which OSD size I setup in vdr-xine (e. g. 720x576, 1280x720 or 1920x1080), the subtitles are never positioned correctly and vdr-xine complains very often like that:
vdr-xine: new OSD(-152, 0) requested with coordinates out of range
I noticed a little different problem with vdr-sxfe (from xineliboutput).
If I first watch some channel on vdr-sxfe client from the small window, the subtitles are positioned ok for me. But once I click the window for full screen mode, the subtitle position and size are not re-calculated and this causes that subtitles are shown in the middle of the screen.
To fix this, I need to switch for another channel and then switch back to original channel.
Mika
On 09.09.2011 21:19, Reinhard Nissl wrote:
Hi,
Am 09.09.2011 16:54, schrieb Klaus Schmidinger:
Since you're saying that the problem is related to the dxr3 plugin I guess I won't see any error with my TT-S2 6400.
I switch to 1.7.21 from 1.7.17 and see that teletext subtitles appear now for example on Das Erste HD.
I assume you mean *DVB* subtitles, right?
No matter which OSD size I setup in vdr-xine (e. g. 720x576, 1280x720 or 1920x1080), the subtitles are never positioned correctly and vdr-xine complains very often like that:
vdr-xine: new OSD(-152, 0) requested with coordinates out of range
Do these subtitles work correctly on your TT-S2 6400?
I tested this with a recent recording of "Wissen vor 8". The subtitles appeared at the right position. However, there was a horizontal, one pixel wide gap in each line, and sometimes the upper text line wasn't erased when I would have expected it to be. The latter may be a bug in VDR or the dvbhddevice plugin. I'll need to look into this some time...
Which OSD size do you use on your TT-S2 6400?
1920x1080.
Klaus
Al 09/09/11 21:19, En/na Reinhard Nissl ha escrit:
No matter which OSD size I setup in vdr-xine (e. g. 720x576, 1280x720 or 1920x1080), the subtitles are never positioned correctly and vdr-xine complains very often like that:
vdr-xine: new OSD(-152, 0) requested with coordinates out of range
Reinhard, I'm using vdr-xine-0.9.3, and after setting the osd to 1920x1080, the subtitles are positioned correctly, at least on the bbc channels on 28.2E, both hd and sd. Previously I had the osd set to 640x480 (IIRC) and either the subtitles didn't show or they were at the left of the screen, vertically in the middle. The "normal" osd on 4:3 channels is compressed horizontally (it still covers the whole width of the screen but the characters are narrow), but the subtitles are fine.
Bye
-
Klaus Schmidinger -
Luca Olivetti -
Mika Laitio -
Reinhard Nissl