I'd like to see the following modifications made to all relevant plugin source files. I don't see why they aren't completely const; they're never modified...
static const char *VERSION => static const char VERSION[] static const char *DESCRIPTION => static const char DESCRIPTION[] static const char *MAINMENUENTRY => static const char MAINMENUENTRY[]
static struct option long_options[] => static const struct ...
Darren Salt wrote:
I'd like to see the following modifications made to all relevant plugin source files. I don't see why they aren't completely const; they're never modified...
static const char *VERSION => static const char VERSION[] static const char *DESCRIPTION => static const char DESCRIPTION[] static const char *MAINMENUENTRY => static const char MAINMENUENTRY[]
static struct option long_options[] => static const struct ...
"static const char *VERSION" is grepped in the default Makefile, so that has to be changed too. All others are private business of plugins and don't even have to exist.
Cheers,
Udo
Darren Salt wrote:
I'd like to see the following modifications made to all relevant plugin source files. I don't see why they aren't completely const; they're never modified...
static const char *VERSION => static const char VERSION[] static const char *DESCRIPTION => static const char DESCRIPTION[] static const char *MAINMENUENTRY => static const char MAINMENUENTRY[]
static struct option long_options[] => static const struct ...
Is there a specific and *urgent* reason for this? It has been this way for years, and apparently works just fine...
Klaus
I demand that Klaus Schmidinger may or may not have written...
Darren Salt wrote:
I'd like to see the following modifications made to all relevant plugin source files. I don't see why they aren't completely const; they're never modified...
static const char *VERSION => static const char VERSION[] static const char *DESCRIPTION => static const char DESCRIPTION[] static const char *MAINMENUENTRY => static const char MAINMENUENTRY[]
static struct option long_options[] => static const struct ...
Is there a specific and *urgent* reason for this? It has been this way for years, and apparently works just fine...
Specific, yes: I'm just doing some minor cleanup.
Darren Salt wrote:
I demand that Klaus Schmidinger may or may not have written...
Darren Salt wrote:
I'd like to see the following modifications made to all relevant plugin source files. I don't see why they aren't completely const; they're never modified...
static const char *VERSION => static const char VERSION[] static const char *DESCRIPTION => static const char DESCRIPTION[] static const char *MAINMENUENTRY => static const char MAINMENUENTRY[]
static struct option long_options[] => static const struct ...
Is there a specific and *urgent* reason for this? It has been this way for years, and apparently works just fine...
Specific, yes: I'm just doing some minor cleanup.
Well, then I'd say we leave it as it is for now.
Klaus
-
Darren Salt -
Klaus Schmidinger -
Udo Richter