Hello,
I have quite a few old recordings with DVB subtitles that were recorded and watchable with 1.4.x and the subtitles plugin. When replaying these with VDR 1.6.0, the subtitles aren't shown (new recordings made with 1.6.0 seem to be fine). I see there's some kind of a "compatibility mode for old subtitles plugin" in 1.6.0 sources, so I guess they should be. Thoughts?
On Sat, 12 Apr 2008, Klaus Schmidinger wrote:
Well, I was the driving force behind the old subtitles compatibility mode and it worked on my recordings made with vdr-1.5.x and subtitles plugin. There were broken subtitles patches that generated faulty recordings (ie. ProjectX didn't like these either), that might be the source of Ville's problem.
BR, -- rofa
On Saturday 12 April 2008, Petri Helin wrote:
After figuring out how to access the subtitles menu (my remote.conf was from 1.4.x series so there was no button binding for it), yes, I do see an entry named "57" there. Selecting it gives me the Finnish subtitles I was looking for. Thanks for the tip.
On Sat, 12 Apr 2008, Petri Helin wrote:
Well, I never had time to figure out where that magic number comes, but my YLE recordings were using those 57/58 track ids (IIRC). I wouldn't add any new legacy burden into VDR as you can achieve the same via a shell script... and you can always use the subtitles key.
BR, -- rofa
Petri Helin wrote:
It is constant. 57 is for the first subtitle track, 58 for the second.
If it is constant, could VDR be patched easily to select "57" in case preferred subtitles are not found?
Yes. Patch attached.
On Saturday 12 April 2008, Rolf Ahrenberg wrote:
I tried to do that, but did not succeed so far.
The old recordings I tried this with had no "X" lines in info.vdr, but they do have this selectable "57" entry in the subtitles menu. New recordings from the same channel (MTV3 Scifi) have both "X 3 03 fin " and "X 3 03 sve " there, and Finnish subtitles do show up automatically when replaying these.
So I tried "X 3 03 fin ", "X 3 57 fin ", and "X 57 03 fin " in the old recordings' info.vdr but that did not seem have any effect. Tried also touching .update and restarting VDR in between, as well as replacing 57 with 39 and 87 (just in case there would have been a dec<->hex conversion somewhere). "SubtitleLanguages = fin 57" hack in setup.conf didn't help either. Did I miss something?
On 04/13/08 09:27, Ville Skyttä wrote:
The old subtitle patch/plugin used 0x28 as the starting offset for subtitle tracks, while the current implementation uses 0x20. I guess this was because the old remux.c had the line
ts2pes[numTracks++] = new cTS2PES(*SPids++, resultBuffer, IPACKS, 0x00, 0x28 + n++);
commented as "future..." and the subtitle patch just enabled this one. When I implemented subtitle handling in the core VDR code, I realized that this should actually be 0x20 instead.
You can work around this by adding the lines
X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 fin suomi
to your info.vdr files. This fills up the first 8 slots and puts "suomi" into the 9th slot.
Don't forget to "touch /video/.update" after this change.
Of course we could also modify cDevice::PlayPesPacket() to subtract 8 from SubStreamIndex in case the "// Compatibility mode for old subtitles plugin" check was positive, but you would still have to add
X 3 03 fin suomi
to your info.vdr files in order to get automatic subtitle track selection. So I guess the above workaround should do just fine.
Klaus
-
Anssi Hannula -
Klaus Schmidinger -
Petri Helin -
Rolf Ahrenberg -
Ville Skyttä