Hi Klaus,
With 1.3.39 and "Menu button closes" set to true, the main menu doesn't open if any replay control is active. The attached patch fixes this by resetting a !IsOpen cControl to WasOpen=false.
Cheers,
Udo
--- vdr-1.3.39-old/vdr.c 2006-01-15 18:33:54.000000000 +0100 +++ vdr-1.3.39/vdr.c 2006-01-15 18:38:28.000000000 +0100 @@ -795,8 +795,12 @@ bool WasMenu = Interact && Interact->IsMenu(); if (Menu) DELETE_MENU; - else if (cControl::Control() && cOsd::IsOpen()) - cControl::Control()->Hide(); + else if (cControl::Control()) { + if (cOsd::IsOpen()) + cControl::Control()->Hide(); + else + WasOpen = false; + } if (!WasOpen || !WasMenu && !Setup.MenuButtonCloses) Menu = new cMenuMain; }
Udo Richter wrote:
With 1.3.39 and "Menu button closes" set to true, the main menu doesn't open if any replay control is active. The attached patch fixes this by resetting a !IsOpen cControl to WasOpen=false.
This slipped the 1.3.40 release somehow, but the attached patch still works.
Cheers,
Udo
En/na Udo Richter ha escrit:
Udo Richter wrote:
With 1.3.39 and "Menu button closes" set to true, the main menu doesn't open if any replay control is active. The attached patch fixes this by resetting a !IsOpen cControl to WasOpen=false.
This slipped the 1.3.40 release somehow, but the attached patch still works.
It's not enough when replaying teletext subtitles (the replay control hides but no menu is shown). I use the attached patch instead (since I don't care about the setting "Menu button closes", I have set it to true). Oh, and I prefer it also because if the recording control is visible it is closed *and* the main menu opens (if only I could do the same with the channel info...)
Bye
Luca Olivetti wrote:
It's not enough when replaying teletext subtitles (the replay control hides but no menu is shown). I use the attached patch instead (since I don't care about the setting "Menu button closes", I have set it to true).
Not being able to open the menu on subtitles is a known issue of the 'Menu button closes' mode, and for now its a wontfix. (see my other patch for a suggestion how to solve this)
With the attached patch, the 'Menu button closes' setting does nothing, and the behavior is just as with 1.3.37, so why don't you just leave 'Menu button closes' at default off and live without any patch?
Cheers,
Udo
En/na Udo Richter ha escrit:
Luca Olivetti wrote:
It's not enough when replaying teletext subtitles (the replay control hides but no menu is shown). I use the attached patch instead (since I don't care about the setting "Menu button closes", I have set it to true).
Not being able to open the menu on subtitles is a known issue of the 'Menu button closes' mode, and for now its a wontfix. (see my other patch for a suggestion how to solve this)
With the attached patch, the 'Menu button closes' setting does nothing, and the behavior is just as with 1.3.37, so why don't you just leave 'Menu button closes' at default off and live without any patch?
With my patch is as if 'Menu button closes' is at *on*, not the default off, and there's a difference in the cControl closing (look at the braces), so it's not the same as without any patch and 'Menu button closes' at on. The main difference though it that it just works with teletext subtitles ;-) and the menu button closes a menu if open. To recap, with my patch the menu button closes the menu if it's open, otherwise opens the main menu. If there's a recording control visible it's closed and the main menu opens. The only drawback is that the channel info is open it's just closed without opening the main menu, but as I said previously this is a bigger problem (that also involves the back key).
Bye
Luca Olivetti wrote:
To recap, with my patch the menu button closes the menu if it's open, otherwise opens the main menu. If there's a recording control visible it's closed and the main menu opens.
Ah, now I see it. These menu key handlings are horribly subtle. Basically, control osds behave the old way, plugin osds behave the new way. Oh, and ontrol()->Hide() is called without the cOsd::IsOpen() test.
The only drawback is that the channel info is open it's just closed without opening the main menu, but as I said previously this is a bigger problem (that also involves the back key).
You can get that with my other patch. To add subtitles support, just add menuKeyAction = menuKeyAlwaysOpens to the subtitles control. (I assume that subtitles are a cControl based osd, right?)
Cheers,
Udo
2006/1/22, Udo Richter udo_richter@gmx.de:
With 1.3.39 and "Menu button closes" set to true, the main menu doesn't open if any replay control is active. The attached patch fixes this by resetting a !IsOpen cControl to WasOpen=false.
This slipped the 1.3.40 release somehow, but the attached patch still works.
Just a remark: It seems, that in 1.3.41 this is still not fixed.
Joachim.
-
Joachim Wilke -
Luca Olivetti -
Udo Richter