Hi Klaus, The behaviour of the menu key was changed with version 1.3.38. In my eyes this new behaviour is not optimal in some cases. e.g. if an OSD message appears and I press the menu key I would like the message to disappear AND the menu should be opened ( if only the message should disappear I'd use another key for it ). I would suggest the following behaviour: The menu key should work menu-oriented, e.g. if no menu is open the mainmenu should be opened ( no matter if a message is currently displayed or not ) and if a menu is open its parent menu should be opened. If its a toplevel menu, but not the main menu, I would prefer that the mainmenu will be opened, instead of just closing this menu. ( For only closing a menu I use the BACK key ). Bye Helmut
vdr@helmutauer.de wrote:
Hi Klaus, The behaviour of the menu key was changed with version 1.3.38. In my eyes this new behaviour is not optimal in some cases. e.g. if an OSD message appears and I press the menu key I would like the message to disappear AND the menu should be opened ( if only the message should disappear I'd use another key for it ). I would suggest the following behaviour: The menu key should work menu-oriented, e.g. if no menu is open the mainmenu should be opened ( no matter if a message is currently displayed or not ) and if a menu is open its parent menu should be opened. If its a toplevel menu, but not the main menu, I would prefer that the mainmenu will be opened, instead of just closing this menu. ( For only closing a menu I use the BACK key ).
There has been a lot of fuss about "the Menu key doesn't behave consistently" in the past. Since IMO there is only _one_ way it can behave consistently, it now opens the main menu if the OSD is empty, and closes whatever is on the OSD if it isn't.
You'll get used to it... ;-)
Klaus
Klaus Schmidinger wrote:
There has been a lot of fuss about "the Menu key doesn't behave consistently" in the past. Since IMO there is only _one_ way it can behave consistently, it now opens the main menu if the OSD is empty, and closes whatever is on the OSD if it isn't.
On a second thought... (oh noooooo...)
Its now consistent for fullscreen OSD, like closing OSDTeletext and similar screen filling uses, but has some side effects I didn't thought of before, as this is also true for small osds that only cover small parts of the screen, like subtitles, the channel info, and the replay (cut marks) display. Mostly this is probably a matter of getting used to it, but especially always-on osds like subtitles can now stop you from opening the menu, if they re-open their osd too fast. I have no really good idea how to handle these cases.
Cheers,
Udo
Udo Richter wrote:
Klaus Schmidinger wrote:
There has been a lot of fuss about "the Menu key doesn't behave consistently" in the past. Since IMO there is only _one_ way it can behave consistently, it now opens the main menu if the OSD is empty, and closes whatever is on the OSD if it isn't.
On a second thought... (oh noooooo...)
Its now consistent for fullscreen OSD, like closing OSDTeletext and similar screen filling uses, but has some side effects I didn't thought of before, as this is also true for small osds that only cover small parts of the screen, like subtitles, the channel info, and the replay (cut marks) display. Mostly this is probably a matter of getting used to it, but especially always-on osds like subtitles can now stop you from opening the menu, if they re-open their osd too fast. I have no really good idea how to handle these cases.
Cheers,
Udo
An integrated solution for subtitles will come in version 1.5.x.
For everything else I believe the current behavior is the only consistent way. Anything else would again open non-consistency discussions.
Sure, if you're used to the old way, the new way may need some getting used to (same here ;-). But I'm sure that's only temporary ;-)
Klaus
Hi,
An integrated solution for subtitles will come in version 1.5.x.
For everything else I believe the current behavior is the only consistent way. Anything else would again open non-consistency discussions.
Sure, if you're used to the old way, the new way may need some getting used to (same here ;-). But I'm sure that's only temporary ;-)
I think it's not consistent. If an OSD message is shown, and I press the timer key, the timer menu is shown. The same with recordings or commands button, but when I press the Menu Button, the Menu is not shown. The menu button should always try to open the mainmenu, the only time that it clears the OSD should be when the mainmenu is already shown.
But there must be some room for patches ;-)
Bye Helmut
Helmut Auer wrote:
Hi,
An integrated solution for subtitles will come in version 1.5.x.
For everything else I believe the current behavior is the only consistent way. Anything else would again open non-consistency discussions.
Sure, if you're used to the old way, the new way may need some getting used to (same here ;-). But I'm sure that's only temporary ;-)
I think it's not consistent. If an OSD message is shown, and I press the timer key, the timer menu is shown. The same with recordings or commands button, but when I press the Menu Button, the Menu is not shown.
These buttons are defined that way. The Timers key, for instance, is a "modeless" key that opens the Timers menu, no matter what (if anything) is currently displayed on the OSD.
The menu button should always try to open the mainmenu, the only time that it clears the OSD should be when the mainmenu is already shown.
But there must be some room for patches ;-)
I want to be able to press one single button to get out of whatever is currently on the OSD - and that's the Menu key. Previously, when I wanted to get rid of the Audio menu, I often found myself pressing the Menu button, just to be annoyed by the fact that it then actually openend the main menu.
Klaus
Hi Klaus,
I want to be able to press one single button to get out of whatever is currently on the OSD - and that's the Menu key.
Why don't you use the BACK ( on most remote controls EXIT ) key for that ?
Previously, when I wanted to get rid of the Audio menu, I often found myself pressing the Menu button, just to be annoyed by the fact that it then actually openend the main menu.
Thats what I like - when pressing menu I want to reach the menu. For clearing OSD I use exit. That's what my wife already understands easily :-)
Hi
Why don't you use the BACK ( on most remote controls EXIT ) key for that ?
Because it goes back only one level.
Ok - now I got you :-) So what about making it customizable: Option 1: - If OSD is used - clear it - if not open Menu Option 2: - like 1 + opening MainMenu
or can I handle this via keymacros ?
Helmut Auer wrote:
Hi
Why don't you use the BACK ( on most remote controls EXIT ) key for that ?
Because it goes back only one level.
Ok - now I got you :-) So what about making it customizable: Option 1:
- If OSD is used - clear it - if not open Menu
Option 2:
- like 1 + opening MainMenu
Ok, before this escalates into a religious war <g> please try this:
--- vdr.c 2006/01/09 16:44:15 1.234 +++ vdr.c 2006/01/10 18:04:40 @@ -787,14 +787,16 @@ // Keys that must work independent of any interactive mode: switch (key) { // Menu control: - case kMenu: + case kMenu: { key = kNone; // nobody else needs to see this key + bool WasMenu = Interact && Interact->IsMenu(); if (Menu) DELETE_MENU; else if (cControl::Control() && cOsd::IsOpen()) cControl::Control()->Hide(); - else + if (!WasMenu) Menu = new cMenuMain; + } break; // Info: case kInfo: {
If this works for you (an others) I'll make this configurable.
Klaus
En/na Klaus Schmidinger ha escrit:
Why don't you use the BACK ( on most remote controls EXIT ) key for that ?
Because it goes back only one level.
but not on plugins that draw their own osd :-( So you now just need to implement the other half of the "consistent key behavior" ;-)
Bye
On Dienstag 10 Januar 2006 17:28, Klaus Schmidinger wrote:
For everything else I believe the current behavior is the only consistent way. Anything else would again open non-consistency discussions.
Sure, if you're used to the old way, the new way may need some getting used to (same here ;-). But I'm sure that's only temporary ;-)
this new behaviour makes the number of key presses to get into the menu unpredictable. It can always happen that some message is displayed just before you press Menu. If that happens you have to press it a second time.
So now you have to check on screen whether the key press really did what you wanted it to do.
The new behaviour is good for the muggle plugin - the Menu key is the preferred way to leave it.
I think this would also be quite consistent:
If the OSD covers less than half of the screen (so if either the upper or the lower part of the screen is without OSD), the Menu key shows the main menu.
Otherwise it clears the OSD.
Wolfgang Rohdewald wrote:
On Dienstag 10 Januar 2006 17:28, Klaus Schmidinger wrote:
For everything else I believe the current behavior is the only consistent way. Anything else would again open non-consistency discussions.
Sure, if you're used to the old way, the new way may need some getting used to (same here ;-). But I'm sure that's only temporary ;-)
this new behaviour makes the number of key presses to get into the menu unpredictable. It can always happen that some message is displayed just before you press Menu. If that happens you have to press it a second time.
So now you have to check on screen whether the key press really did what you wanted it to do.
The new behaviour is good for the muggle plugin - the Menu key is the preferred way to leave it.
I think this would also be quite consistent:
If the OSD covers less than half of the screen (so if either the upper or the lower part of the screen is without OSD), the Menu key shows the main menu.
Otherwise it clears the OSD.
I can already see people counting pixels and arguing whether this or that menu actually covered more than half of the screen ;-)
Klaus
En/na Klaus Schmidinger ha escrit:
An integrated solution for subtitles will come in version 1.5.x.
dvb, teletext or both? compatible with existing recordings made with the corresponding plugins?
Bye
Luca Olivetti wrote:
En/na Klaus Schmidinger ha escrit:
An integrated solution for subtitles will come in version 1.5.x.
dvb, teletext or both? compatible with existing recordings made with the corresponding plugins?
I'll cross those bridges when I get there ;-)
Klaus
On Wed, 2006-01-11 at 00:10 +0100, Klaus Schmidinger wrote:
Luca Olivetti wrote:
En/na Klaus Schmidinger ha escrit:
An integrated solution for subtitles will come in version 1.5.x.
dvb, teletext or both? compatible with existing recordings made with the corresponding plugins?
I'll cross those bridges when I get there ;-)
Perhaps there needs to be a distinction between an 'informational' osd and an 'interactive' osd?
Ie: subtitles, and mesg messages etc are just informational. In fact, the user did not ask for them to be displayed (at least not via the remote). In this case the menu key should open the menu.
In all other cases, the menu key can close the OSD.
Klaus
vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
-
Carsten Presser -
Helmut Auer -
Klaus Schmidinger -
Luca Olivetti -
Malcolm Caldwell -
Udo Richter -
vdr＠helmutauer.de
-
Wolfgang Rohdewald