I'm just wondering, if there has happened a mistake in updating the Makefile in VDR 1.7.15.
The HISTORY file states: "Include paths are now added instead of overwriting INCLUDES in the Makefile"
However, in the Makefile changes: -INCLUDES = -I/usr/include/freetype2 +INCLUDES ?= -I/usr/include/freetype2
Shouldn't that be += instead of ?=.
In my case, my IDE sets INCLUDES with some custom stuff. Therefore the Makefile does not touch INCLUDES any more and I get an error.
On Friday 19 November 2010, 20:19:20 Joachim Wilke wrote:
No, the conditional variable assignment operator ?= allows one to replace this variable via command line/environment.
In my case, my IDE sets INCLUDES with some custom stuff. Therefore the Makefile does not touch INCLUDES any more and I get an error.
If your IDE mangles INCLUDES (?!?), just add "-I/usr/include/freetype2" to the mess..
Pete
2010/11/19 Hans-Peter Jansen hpj@urpla.net:
Thats not what the HISTORY reads. Either the Makefile or the HISTORY should be changed.
VDR Makefile should take care to always include the default, even if I add other paths to my local INCLUDES. Adding it manually would really result in a mess.
On 20.11.2010 11:39, Joachim Wilke wrote:
This change was posted here on the list by Paul Menzel on 2010-04-05. I guess the phrase "Include paths are now added instead of overwriting..." in the HISTORY was my fault.
@Paul: would it be ok with you to make this
INCLUDES += -I/usr/include/freetype2
instead of
INCLUDES ?= -I/usr/include/freetype2
Klaus
Am Sonntag, den 12.12.2010, 16:29 +0100 schrieb Klaus Schmidinger:
The link to the message in the archive is [1].
Reading my commit message,
In some environments, i. e. when cross building, include files are not located in the standard path like `/usr/includes/freetype2`. Make it possible to provide the correct path without needing to patch `Makefile`.
I would say that it would not work when cross compiling. I am no expert though. I would recommend to change the entry in HISTORY and I will ask on openembedded-devel what they suggest.
Thanks,
Paul
[1] http://www.linuxtv.org/pipermail/vdr/2010-April/022831.html
Am Sonntag, den 12.12.2010, 16:46 +0100 schrieb Paul Menzel:
My message already got an answer [2] which advises to use `pkg-config`.
IMO you should use pkg-config or freetype-config instead, e.g.:
INCLUDES ?= `pkg-config --cflags freetype2`
or better, instead of using INCLUDES at all:
FREETYPE_CFLAGS ?= `pkg-config --cflags freetype2` CFLAGS += $(FREETYPE_CFLAGS)
This will work in most environments.
Thanks,
Paul
[1] http://www.linuxtv.org/pipermail/vdr/2010-April/022831.html
[2] http://lists.linuxtogo.org/pipermail/openembedded-devel/2010-December/027801...
-
Hans-Peter Jansen -
Joachim Wilke -
Klaus Schmidinger -
Paul Menzel